Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expand DevMode flag to set values for external access #601

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Sep 13, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run non-secure edgex stack
Build Device SImple (Go Device SDK) with this branch
run Device SImple in Dev Mode (./device-simple -cp -d -o)
Verify Simple-Device01 was added as a device to Core MetaData (via Edgex UI)
Send following command to Core Command

curl http://localhost:59882/api/v3/device/name/Simple-Device01/Switch

Verify 200 response and a new Event is returned.

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added the bug Something isn't working label Sep 13, 2023
@lenny-goodell lenny-goodell added this to the Napa milestone Sep 13, 2023
@bnevis-i
Copy link
Collaborator

I don't get what this code does or why it works.

@codecov-commenter
Copy link

Codecov Report

Merging #601 (14c1edc) into main (5491853) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   58.79%   58.56%   -0.24%     
==========================================
  Files          31       31              
  Lines        2524     2534      +10     
==========================================
  Hits         1484     1484              
- Misses        943      953      +10     
  Partials       97       97              
Files Changed Coverage Δ
bootstrap/config/config.go 32.21% <0.00%> (-0.53%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants