feat: add better error handlings when common config is missing #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives a better error messages when the developer runs with hybrid mode but not including common config. Closes: edgexfoundry#564 Signed-off-by: Jim Wang <[email protected]>
lenny-goodell
requested changes
Jul 19, 2023
bootstrap/handlers/clients.go
Outdated
| @@ -110,6 +110,11 @@ func (cb *ClientsBootstrap) BootstrapHandler( | |||
| return false | |||
| } | |||
|
|
|||
| if len(config.GetBootstrap().Service.RequestTimeout) == 0 { | |||
| lc.Error("Service.RequestTimeout found empty in bootstrap config, missing common config? Use -cp or -cc flags for common config") | |||
There was a problem hiding this comment.
Suggested change
| lc.Error("Service.RequestTimeout found empty in bootstrap config, missing common config? Use -cp or -cc flags for common config") | |
| lc.Error("Service.RequestTimeout found empty in service's configuration, missing common config? Use -cp or -cc flags for common config") |
There was a problem hiding this comment.
all suggestions updated
Signed-off-by: Jim Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a better error messages when the developer runs with hybrid mode but not including common config.
Closes: #564
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
makefirst from the base root of device-sdk repo to compile the device-sdk together with the local go-mod-bootstrapcd ./example/cmd/device-simplemake./device-simplewithout any flags like -cc or -d"Service.RequestTime found empty in bootstrap conifg, missing common config? Use -cp or -cc flags for common config"New Dependency Instructions (If applicable)