Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move all the common APIs into go-mod-bootstrap #562

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

jinlinGuan
Copy link
Contributor

close #478

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@jinlinGuan jinlinGuan marked this pull request as draft July 14, 2023 10:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #562 (ee5da3c) into main (b171584) will increase coverage by 0.49%.
The diff coverage is 70.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   58.20%   58.69%   +0.49%     
==========================================
  Files          28       29       +1     
  Lines        2292     2392     +100     
==========================================
+ Hits         1334     1404      +70     
- Misses        871      898      +27     
- Partials       87       90       +3     
Impacted Files Coverage Δ
bootstrap/utils/utils.go 48.97% <0.00%> (-14.18%) ⬇️
bootstrap/controller/commonapi.go 89.74% <89.74%> (ø)

bootstrap/controller/commonapi.go Outdated Show resolved Hide resolved
bootstrap/controller/commonapi.go Outdated Show resolved Hide resolved
bootstrap/controller/commonapi.go Outdated Show resolved Hide resolved
bootstrap/controller/commonapi.go Outdated Show resolved Hide resolved
bootstrap/controller/commonapi.go Outdated Show resolved Hide resolved
bootstrap/controller/commonapi_test.go Outdated Show resolved Hide resolved
bootstrap/controller/commonapi_test.go Outdated Show resolved Hide resolved
bootstrap/controller/commonapi_test.go Outdated Show resolved Hide resolved
bootstrap/utils/utils.go Outdated Show resolved Hide resolved
Also update script according to the comments

Signed-off-by: Ginny Guan <[email protected]>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinlinGuan jinlinGuan marked this pull request as ready for review July 18, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all the common API into go-mod-bootstrap
4 participants