Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use loadfile that allows reading Config from local file or uri #558

Merged
merged 8 commits into from
Jul 17, 2023

Conversation

brian-intel
Copy link
Contributor

close #553

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  • add EDGEX_CONFIG_FILE= to any service
  • start edgex in secure or no-secure mode
  • Modified service should get config from the remote location instead of the local copy.

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #558 (078d553) into main (d15a138) will increase coverage by 0.30%.
The diff coverage is 72.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   57.84%   58.15%   +0.30%     
==========================================
  Files          28       28              
  Lines        2275     2282       +7     
==========================================
+ Hits         1316     1327      +11     
+ Misses        871      869       -2     
+ Partials       88       86       -2     
Impacted Files Coverage Δ
bootstrap/config/config.go 31.61% <72.22%> (+0.83%) ⬆️

... and 1 file with indirect coverage changes

bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/environment/variables.go Outdated Show resolved Hide resolved
bootstrap/environment/variables.go Show resolved Hide resolved
bootstrap/environment/variables.go Outdated Show resolved Hide resolved
bootstrap/environment/variables.go Outdated Show resolved Hide resolved
bootstrap/environment/variables.go Outdated Show resolved Hide resolved
bootstrap/flags/flags.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some improvement suggestions

bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/environment/variables.go Outdated Show resolved Hide resolved
bootstrap/environment/variables_test.go Outdated Show resolved Hide resolved
bootstrap/environment/variables_test.go Outdated Show resolved Hide resolved
Signed-off-by: Brian McGinn <[email protected]>
bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/config/config_test.go Show resolved Hide resolved
bootstrap/environment/variables.go Outdated Show resolved Hide resolved
bootstrap/config/config.go Outdated Show resolved Hide resolved
@lenny-goodell lenny-goodell marked this pull request as ready for review July 17, 2023 20:58
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but LGTM

bootstrap/file/file.go Show resolved Hide resolved
@lenny-goodell lenny-goodell merged commit b171584 into edgexfoundry:main Jul 17, 2023
@lenny-goodell lenny-goodell changed the title feat: Use loadfile that allows reading from local file or uri feat: Use loadfile that allows reading Config from local file or uri Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[URI4Files] Go- Refactor loading Config file to handle URI
5 participants