-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use loadfile that allows reading Config from local file or uri #558
feat: Use loadfile that allows reading Config from local file or uri #558
Conversation
close edgexfoundry#553 Signed-off-by: Brian McGinn <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 57.84% 58.15% +0.30%
==========================================
Files 28 28
Lines 2275 2282 +7
==========================================
+ Hits 1316 1327 +11
+ Misses 871 869 -2
+ Partials 88 86 -2
|
Signed-off-by: Brian McGinn <[email protected]>
Signed-off-by: Brian McGinn <[email protected]>
9c12ba0
to
812304d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some improvement suggestions
Signed-off-by: Brian McGinn <[email protected]>
e47017d
to
615ae35
Compare
Signed-off-by: Brian McGinn <[email protected]>
Signed-off-by: Brian McGinn <[email protected]>
Signed-off-by: Brian McGinn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment, but LGTM
close #553
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)