Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InsecureSecrets change detection #525

Merged
merged 1 commit into from
May 1, 2023

Conversation

ajcasagrande
Copy link
Contributor

fixes #524

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • [n/a?] I have opened a PR for the related docs change (if not, why?)
    N/A due to no functionality change

Testing Instructions

  • Run EdgeX in non-secure mode
  • Run a service with a secret callback code
  • Change an InsecureSecret
  • Verify that the callback was triggered

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #525 (dbf178c) into main (da8ce12) will decrease coverage by 0.11%.
The diff coverage is 30.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   57.89%   57.79%   -0.11%     
==========================================
  Files          27       27              
  Lines        2190     2199       +9     
==========================================
+ Hits         1268     1271       +3     
- Misses        842      846       +4     
- Partials       80       82       +2     
Impacted Files Coverage Δ
bootstrap/config/config.go 31.26% <0.00%> (-0.12%) ⬇️
bootstrap/utils/utils.go 63.15% <42.85%> (-2.06%) ⬇️

Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit a09e027 into edgexfoundry:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InsecureSecrets change detection does not work
4 participants