Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to Go 1.20 and linter v1.51.2 #470

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Mar 13, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • [] I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

make sure v1.51.2 of linter is installed
make test
verify no format or linter issues

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #470 (e414d03) into main (372c5e0) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files          26       26           
  Lines        2036     2036           
=======================================
  Hits         1166     1166           
  Misses        799      799           
  Partials       71       71           
Impacted Files Coverage Δ
bootstrap/handlers/auth_middleware.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lenny-goodell lenny-goodell merged commit 86c0411 into edgexfoundry:main Mar 13, 2023
@lenny-goodell lenny-goodell deleted the go-1.20 branch March 13, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants