Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use updated config provider function for isCommonConfigReady #450

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

ejlee3
Copy link
Contributor

@ejlee3 ejlee3 commented Feb 24, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) - docs need to be added for common config

Testing Instructions

Non-secure mode testing

  1. set the environment variable for non-secure testing export EDGEX_SECURITY_SECRET_STORE=false
  2. run the latest compose builder make run no-secty to start core services
  3. stop core data
  4. remove the core data configuration in consul
  5. modify local go-mod in edgex-go to use bootstrap from this branch and config from this branch using replace statement
  6. build common config and core data make data
  7. run core-data locally and ensure that the configuration loads cd cmd/core-data and ./core-data -cp
  8. Verify that the core data configuration was loaded into consul
  9. Modify the writable log level and ensure the terminal reflects the change

Secure mode testing

  1. set the environment variable for non-secure testing export EDGEX_SECURITY_SECRET_STORE=true
  2. run the latest compose builder make run to start core services
  3. stop core data
  4. remove the core data configuration in consul
  5. modify local go-mod in edgex-go to use bootstrap from this branch and config from this branch using replace statement
  6. build common config and core data make data
  7. run core-data locally and ensure that the configuration loads cd cmd/core-data and sudo ./core-data -cp
  8. Verify that the core data configuration was loaded into consul
  9. Modify the writable log level and ensure the terminal reflects the change

New Dependency Instructions (If applicable)

bootstrap/config/config.go Outdated Show resolved Hide resolved
bootstrap/config/config.go Outdated Show resolved Hide resolved
Signed-off-by: Elizabeth J Lee <[email protected]>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejlee3 ejlee3 marked this pull request as ready for review February 27, 2023 18:02
@lenny-goodell lenny-goodell merged commit e72e993 into edgexfoundry:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants