Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add capability to use messaging based Command Client #384

Merged
merged 3 commits into from
Oct 21, 2022
Merged

feat: Add capability to use messaging based Command Client #384

merged 3 commits into from
Oct 21, 2022

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Oct 19, 2022 •
edited
Loading

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) Full testing will be done in App SDK PR
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

N/A

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell changed the title Messaging client feat: Add capability to use messaging based Command Client Oct 19, 2022
@lenny-goodell
Copy link
Member Author

@cloudxxx8 , If you merge, please Sqaush and Merge and remove the first commit message. Not sure how that got there, but the list of changed files is correct. THX!

@lenny-goodell lenny-goodell mentioned this pull request Oct 19, 2022
Merged
5 tasks
chr1shung
chr1shung suggested changes Oct 20, 2022
View reviewed changes
bootstrap/handlers/clients.go Outdated Show resolved Hide resolved
bootstrap/handlers/clients.go Show resolved Hide resolved
chr1shung
chr1shung approved these changes Oct 21, 2022
View reviewed changes
Copy link

@chr1shung chr1shung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell
Copy link
Member Author

@cloudxxx8 , need your approval as committer

@lenny-goodell lenny-goodell merged commit 9ad12a8 into edgexfoundry:main Oct 21, 2022
@lenny-goodell lenny-goodell deleted the messaging-client branch October 21, 2022 18:15
FelixTing pushed a commit to IOTechSystems/go-mod-bootstrap that referenced this pull request Nov 2, 2022
@FelixTing
feat: Add capability to use messaging based Command Client (edgexfou…
28d3c45 
…ndry#384)

* feat: Add capability to use messaging based Command Client

closes edgexfoundry#382

Signed-off-by: Leonard Goodell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@chr1shung chr1shung chr1shung approved these changes

@cloudxxx8 cloudxxx8 Awaiting requested review from cloudxxx8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lenny-goodell @chr1shung @jim-wang-intel