Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new 'Topics' field and external MQTT BootstrapHandler #365

Merged
merged 2 commits into from
Aug 25, 2022
Merged

feat: add new 'Topics' field and external MQTT BootstrapHandler #365

merged 2 commits into from
Aug 25, 2022

Conversation

chr1shung
Copy link

@chr1shung chr1shung commented Aug 22, 2022

to support north-south messaging implementation for internal and
external MessageBus connection

Signed-off-by: Chris Hung [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) new handler depends on mqtt-broker, haven't figured out how to test it
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) wait until the whole implementation is finished

Testing Instructions

New Dependency Instructions (If applicable)

https://github.com/eclipse/paho.mqtt.golang
used by app-functions-sdk-go to connect to external MQTT broker.
We extract the logic here so that it can be reused by north-south messaging implementation and app-sdk in the future.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #365 (0669cbd) into main (8679ad0) will decrease coverage by 3.80%.
The diff coverage is 1.03%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   61.52%   57.72%   -3.81%     
==========================================
  Files          23       24       +1     
  Lines        1458     1554      +96     
==========================================
  Hits          897      897              
- Misses        523      619      +96     
  Partials       38       38              
Impacted Files Coverage Δ
bootstrap/handlers/externalmqtt.go 0.00% <0.00%> (ø)
config/types.go 35.29% <ø> (ø)
bootstrap/handlers/messaging.go 83.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bootstrap/handlers/messaging.go Outdated Show resolved Hide resolved
bootstrap/handlers/messaging.go Outdated Show resolved Hide resolved
bootstrap/container/messaging.go Outdated Show resolved Hide resolved
bootstrap/container/messaging.go Outdated Show resolved Hide resolved
bootstrap/container/messaging.go Outdated Show resolved Hide resolved
allow MessageBusInfo to be more flexible with respects to topics
for north-south messaging implementation and future EdgeX 3.0 usage.

Signed-off-by: Chris Hung <[email protected]>
@chr1shung chr1shung changed the title feat: add new Messaging BootstrapHandler feat: add new 'Topics' field and external MQTT BootstrapHandler Aug 24, 2022
bootstrap/handlers/externalmqtt.go Outdated Show resolved Hide resolved
bootstrap/handlers/externalmqtt.go Show resolved Hide resolved
bootstrap/container/externalmqtt.go Outdated Show resolved Hide resolved
bootstrap/container/externalmqtt.go Outdated Show resolved Hide resolved
bootstrap/container/externalmqtt.go Outdated Show resolved Hide resolved
bootstrap/container/externalmqtt.go Outdated Show resolved Hide resolved
bootstrap/handlers/externalmqtt.go Show resolved Hide resolved
bootstrap/handlers/externalmqtt.go Show resolved Hide resolved
@chr1shung chr1shung requested review from lenny-goodell and FelixTing and removed request for lenny-goodell and FelixTing August 25, 2022 03:42
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 6dab13b into edgexfoundry:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants