-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new 'Topics' field and external MQTT BootstrapHandler #365
Merged
lenny-goodell
merged 2 commits into
edgexfoundry:main
from
chr1shung:north-south-messaging
Aug 25, 2022
Merged
feat: add new 'Topics' field and external MQTT BootstrapHandler #365
lenny-goodell
merged 2 commits into
edgexfoundry:main
from
chr1shung:north-south-messaging
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 61.52% 57.72% -3.81%
==========================================
Files 23 24 +1
Lines 1458 1554 +96
==========================================
Hits 897 897
- Misses 523 619 +96
Partials 38 38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5 tasks
lenny-goodell
requested changes
Aug 22, 2022
allow MessageBusInfo to be more flexible with respects to topics for north-south messaging implementation and future EdgeX 3.0 usage. Signed-off-by: Chris Hung <[email protected]>
chr1shung
changed the title
feat: add new Messaging BootstrapHandler
feat: add new 'Topics' field and external MQTT BootstrapHandler
Aug 24, 2022
lenny-goodell
requested changes
Aug 24, 2022
FelixTing
reviewed
Aug 25, 2022
Signed-off-by: Chris Hung <[email protected]>
chr1shung
requested review from
lenny-goodell and
FelixTing
and removed request for
lenny-goodell and
FelixTing
August 25, 2022 03:42
lenny-goodell
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to support north-south messaging implementation for internal and
external MessageBus connection
Signed-off-by: Chris Hung [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)
https://github.com/eclipse/paho.mqtt.golang
used by app-functions-sdk-go to connect to external MQTT broker.
We extract the logic here so that it can be reused by north-south messaging implementation and app-sdk in the future.