-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added "make lint" target and added to "make test" target #302
Conversation
Signed-off-by: Marc-Philippe Fuller <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 53.67% 53.67%
=======================================
Files 17 17
Lines 1008 1008
=======================================
Hits 541 541
Misses 446 446
Partials 21 21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One optional change that I've made to the other Makefiles is to break out "go test" into a "unittest" target.
That way, the unit tests (the most important thing) run first, then the linter, then vet, gofmt, etc.
…y lint Signed-off-by: Marc-Philippe Fuller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…foundry#302) * feat: Added golangci-lint to makefile Signed-off-by: Marc-Philippe Fuller <[email protected]>
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Ran edgex-go using local go-mod-bootstrap in both security and no-secty to make sure everything came up and no errors in logs
New Dependency Instructions (If applicable)
N/A