refactor: update calling GenerateConsulToken #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
the API for calling GenerateConsulToken has changed from go-mod-secret and thus requires a change Fixes: #211 Signed-off-by: Jim Wang <[email protected]>
jim-wang-intel
force-pushed
the
update-call-gen-consul-token
branch
from
57c7d0f to
fe2e56e
Compare
|
recheck |
lenny-goodell
approved these changes
Apr 15, 2021
lenny-goodell
referenced
this pull request
in lenny-goodell/go-mod-bootstrap
Apr 20, 2021
Hyphen is not a standard character for environment varable names closes #212 Signed-off-by: lenny <[email protected]>
lenny-goodell
referenced
this pull request
in lenny-goodell/go-mod-bootstrap
Apr 20, 2021
Hyphen is not a standard character for environment variable names closes #212 Signed-off-by: lenny <[email protected]>
lenny-goodell
referenced
this pull request
in lenny-goodell/go-mod-bootstrap
Apr 20, 2021
Hyphen is not a standard character for environment variable names closes #212 BREAKING CHANGE: Overrides that have hyphens will not longer work and must be updated replace hyphens with underscores. Signed-off-by: lenny <[email protected]>
6 tasks
lenny-goodell
referenced
this pull request
in lenny-goodell/go-mod-bootstrap
May 3, 2021
Hyphen is not a standard character for environment variable names closes #212 BREAKING CHANGE: Overrides that have hyphens will not longer work and must be updated replace hyphens with underscores. Signed-off-by: lenny <[email protected]>
lenny-goodell
pushed a commit
that referenced
this pull request
May 17, 2021
* fix: Replace hyphen with underscore in override names Hyphen is not a standard character for environment variable names closes #212 BREAKING CHANGE: Overrides that have hyphens will not longer work and must be updated replace hyphens with underscores. Signed-off-by: lenny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the API for calling GenerateConsulToken has changed from go-mod-secret and thus requires a change
Fixes: #211
Signed-off-by: Jim Wang [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/master/.github/Contributing.md.
What is the current behavior?
interface changed
Issue Number: #211
What is the new behavior?
updated according to interface change
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information