refactor: Set the Config Version when creating Config Client #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This centralizes the config version for all services. closes #200 BREAKING CHANGE: Configuration in Consul now under the `/2.0/` path Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
config-version
branch
from
63e280f to
61a3f34
Compare
jpwhitemn
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #200
Signed-off-by: lenny [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/master/.github/Contributing.md.
What is the current behavior?
Config version set separately by Core/Support, App and Device services.
Issue Number: #200
What is the new behavior?
This centralizes the config version for all Go services.
Does this PR introduce a breaking change?
BREAKING CHANGE: Configuration in Consul now under the
/2.0/pathNew Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information