-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for highlighted diffs #41
Comments
@dtolnay Would it be possible to introduce |
Can you give an example output when you need a diff but it is not shown? There are heuristics that determine when a diff is worth showing and we can adjust those. |
Expected
Actual
|
Yep, it says at the top of the issue this is currently unix-only. Termcolor would need a highlighting implementation for windows before I would try to make it work there. |
IIRC termcolor has support for windows and we used that for clap. Not sure what the issue here is. |
Requires opt-in for now (
cargo test --features trybuild/diff
).Currently unix-only. We will need to look into how to get highlighted background color reliably on Windows terminals, and ideally implement support for it in https://github.com/BurntSushi/termcolor.
Our diff algorithm is backed by https://github.com/dtolnay/dissimilar which is intended to produce human readable diffs with less noise than raw Myers' algorithm.
The intended output looks like:
The text was updated successfully, but these errors were encountered: