Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lc-admin does not default to tcp transport #395

Closed
sysmonk opened this issue Oct 19, 2022 · 2 comments
Closed

lc-admin does not default to tcp transport #395

sysmonk opened this issue Oct 19, 2022 · 2 comments
Labels

Comments

@sysmonk
Copy link
Contributor

sysmonk commented Oct 19, 2022

The documentation here says:
If no transport name is specified, "tcp" is assumed.
And even has a "transportless" example below 127.0.0.1:1234

But in reality, lc-admin still requirers to specify a transport:

~# lc-admin -connect :127.0.0.1:12345
Admin version 2.9.1

Setting up client for :127.0.0.1:12345...
Error: unknown transport specified for admin bind: ''
~# lc-admin -connect tcp:127.0.0.1:12345
Admin version 2.9.1

Setting up client for tcp:127.0.0.1:12345...
Detected remote Log Courier v2.9.0

~#

this if on v 2.9.1, but 2.9.0 was the same, didn't check the versions before.

@driskell
Copy link
Owner

Ah - you need to say 127.0.0.1:12345 instead of with the proceeding colon.
I can make it handle it though for next version. It was checking for the existence of only one colon rather than handling both formats and checking for an empty value

@driskell
Copy link
Owner

Ah and yes it doesn't work without the colon anyway either, due to the port:

Setting up client for 127.0.0.1:12340...
Error: unknown transport specified for admin bind: '127.0.0.1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants