Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model change detected because of newlines across Windows/Unix #35382

Open
roji opened this issue Dec 23, 2024 · 0 comments
Open

Model change detected because of newlines across Windows/Unix #35382

roji opened this issue Dec 23, 2024 · 0 comments

Comments

@roji
Copy link
Member

roji commented Dec 23, 2024

SQL strings in various parts of the model (e.g. default value SQL, filters...) may embed newlines, and if they do, falsely trigger a model change (and therefore a PendingModelChangesWarning). We should consider normalizing newlines for the purpose of model diffing to prevent this.

Reported by @dcby in #35285 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant