Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken built-in Sysbench tests #443

Closed
coffeegoddd opened this issue Jun 26, 2024 · 4 comments
Closed

Broken built-in Sysbench tests #443

coffeegoddd opened this issue Jun 26, 2024 · 4 comments
Assignees

Comments

@coffeegoddd
Copy link
Contributor

Current sysbench tests that break with doltgres main (562199f):

test: oltp_read_only
error: time="2024-06-26T21:40:00Z" level=warning msg="error running query" connectTime="2024-06-26 21:40:00.985446435 +0000 UTC m=+10.540577350" connectionDb=test connectionID=7 error="Unimplemented Sum.Eval(). The code should have used AggregationBuffer.Eval(ctx)."
time="2024-06-26T21:40:01Z" level=info msg=ConnectionClosed connectionID=7
sysbench 1.0.20 (using system LuaJIT 2.1.0-beta3)

Running the test with following options:
Number of threads: 1
Initializing random number generator from seed (1).


Initializing worker threads...

Threads started!

FATAL: PQexec() failed: 7 Unimplemented Sum.Eval(). The code should have used AggregationBuffer.Eval(ctx). (errno 1105) (sqlstate HY000)
FATAL: failed query was: SELECT SUM(k) FROM sbtest1 WHERE id BETWEEN 7422 AND 7521
FATAL: `thread_run' function failed: /usr/share/sysbench/oltp_common.lua:432: SQL error, errno = 0, state = 'XX000': Unimplemented Sum.Eval(). The code should have used AggregationBuffer.Eval(ctx). (errno 1105) (sqlstate HY000)
sysbench 1.0.20 (using system LuaJIT 2.1.0-beta3)
test: select_random_points
error: time="2024-06-26T21:46:13Z" level=warning msg="error running query" connectTime="2024-06-26 21:46:13.168895556 +0000 UTC m=+372.137216216" connectionDb=test connectionID=15 error="operator does not exist: integer = bigint"
time="2024-06-26T21:46:13Z" level=info msg=ConnectionClosed connectionID=15
sysbench 1.0.20 (using system LuaJIT 2.1.0-beta3)

Running the test with following options:
Number of threads: 1
Initializing random number generator from seed (1).


Initializing worker threads...

Threads started!

FATAL: PQexec() failed: 7 operator does not exist: integer = bigint (errno 1105) (sqlstate HY000)
FATAL: failed query was:         SELECT id, k, c, pad
          FROM sbtest1
          WHERE k IN (8117, 3761, 8948, 6213, 8021, 6261, 4100, 1967, 9875, 1156)
        
FATAL: `thread_run' function failed: /usr/share/sysbench/select_random_points.lua:71: SQL error, errno = 0, state = 'XX000': operator does not exist: integer = bigint (errno 1105) (sqlstate HY000)
sysbench 1.0.20 (using system LuaJIT 2.1.0-beta3)
test: oltp_read_write
error: time="2024-06-26T21:50:24Z" level=warning msg="error running query" connectTime="2024-06-26 21:50:24.830688578 +0000 UTC m=+251.466539764" connectionDb=test connectionID=11 error="Unimplemented Sum.Eval(). The code should have used AggregationBuffer.Eval(ctx)."
sysbench 1.0.20 (using system LuaJIT 2.1.0-beta3)

Running the test with following options:
Number of threads: 1
Initializing random number generator from seed (1).


Initializing worker threads...

Threads started!

FATAL: PQexec() failed: 7 Unimplemented Sum.Eval(). The code should have used AggregationBuffer.Eval(ctx). (errno 1105) (sqlstate HY000)
FATAL: failed query was: SELECT SUM(k) FROM sbtest1 WHERE id BETWEEN 7422 AND 7521
FATAL: `thread_run' function failed: /usr/share/sysbench/oltp_common.lua:432: SQL error, errno = 0, state = 'XX000': Unimplemented Sum.Eval(). The code should have used AggregationBuffer.Eval(ctx). (errno 1105) (sqlstate HY000)
time="2024-06-26T21:50:24Z" level=info msg=ConnectionClosed connectionID=11
sysbench 1.0.20 (using system LuaJIT 2.1.0-beta3)
@zachmu
Copy link
Member

zachmu commented Jun 27, 2024

Doltgres scripts fixed here:

dolthub/sysbench-lua-scripts#14

Tests re-enabled here:

dolthub/dolt#8080

@zachmu
Copy link
Member

zachmu commented Jun 27, 2024

To repro these failures, run the run-postgres-scripts.sh in root of the sysbench-lua-scripts repo. Before doing so, start the Doltgres server and run CREATE DATABASE sbtest. You have to have the sysbench tool installed as well.

@zachmu zachmu assigned Hydrocharged and unassigned zachmu Jun 27, 2024
@Hydrocharged
Copy link
Collaborator

#436
All of the aforementioned issues are fixed in the above PR, which was just merged.

@zachmu zachmu reopened this Jun 27, 2024
@zachmu
Copy link
Member

zachmu commented Jun 27, 2024

Let's wait for a successful run before we close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants