-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error parsing {token}s #125
Comments
interesting options.... have you looked at how say handlebars does this? might be safest to stick with something familiar. on the other hand, i kind of find interesting the possibility of having the option as a developer. In some cases, I may want to opt out of handlebars does as for failure defaults, i'd say |
VERY modern JS pattern right there my man. Ancient ruby pattern tho. #ISeeWhatYouDidThere #NowYouGetIt However you'd do that within the computed <foo-bar> {message} </foo-bar>
<script>
Element `foo-bar`
(class extends HTMLElement {
get message ()
{ return undefined || 'default message' }
})
</script> That would be ok @brandondees however the #CATAT /cc @tmornini @kurtcagle @rianby64 |
I'd suggest HTML escaping the {token} if there's no match. |
or @tmornini 's suggestion, which probably makes the most sense |
@brandondees @tmornini @Robertchristopher @btakita formal discussion over @ WHATWG |
Hello, this isn't really an issue so as it's related to the token parsing I'll add it here 🙃. Thanks! |
This question leads to the possibility to customize the token... and, by default it could be And what about the compatibility with the standard? |
Currently if a
{token}
is found within a component we search for a property of the same name on theclaas
definition. However if the token is not available we returnundefined
this is printing to the DOM. We can do the following:undefined
as a hed nod to change.{fields}
to actually display not get parsed.This brings up another question. Do we have to escape?
{{token}}
would render{token}
<< TO BE CLEAR I DON'T LIKE THAT. I just want to know the best way to "Escape" a token.Please advise
The text was updated successfully, but these errors were encountered: