-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webdriverjs 4.7.3 broke default export in CJS #948
Labels
in sprint
Ticket is in current sprint
PACKAGE: webdriverjs
QA: required
This ticket requires QA signoff
signOff-QA
Comments
straker
changed the title
fix: allow cjs version of packages to export a default value
webdriverjs 4.7.3 broke default export in CJS
Nov 27, 2023
Verified with the latest canary build (axe-core-npm_4.8.2-4af4d7d.0) 1. CJS
testSnippet:
test snippet:
2. MJS
test snippet:
3. TS
test snippet:
Environment:
|
Verified with the latest canary build (axe-core-npm_4.8.3-6b60442.0) 1. CJS
testSnippet:
test snippet:
2. MJS
test snippet:
3. TS
test snippet:
Environment:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in sprint
Ticket is in current sprint
PACKAGE: webdriverjs
QA: required
This ticket requires QA signoff
signOff-QA
In v4.7.3 we released webdriverjs with a breaking change where we broke the default export and changed it to a
.default
export (in CJS). We need to fix this and go back to the default export, but since this is now released we also need to support the.default
export so we don't break anyone using v4.7.3.QA NOTES: We'll be supporting both default and
.default
exports in all our packages going forward, and some packages will also have a named export. Tests will need to be set up in both ESM and commonJS format to import / require (respectively) the default export and possibly named export, and in CJS require the.default
export.The text was updated successfully, but these errors were encountered: