-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Enable program to work with pkg
#48
Conversation
packages/cli/lib/axe-test-urls.js
Outdated
const callback = arguments[arguments.length-1] | ||
const script = document.createElement('script') | ||
script.innerHTML = 'document.documentElement.classList.add("deque-axe-is-ready");' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make sure this can continue to work on IE:
const callback = arguments[arguments.length-1] | |
const script = document.createElement('script') | |
script.innerHTML = 'document.documentElement.classList.add("deque-axe-is-ready");' | |
var callback = arguments[arguments.length-1] | |
var script = document.createElement('script') | |
script.innerHTML = 'document.documentElement.classList.add("deque-axe-is-ready");' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI program relies on @axe-core/webdriverjs
, which uses Array#from
, global.Promise
, "arrow functions" and other JS features that do not work in IE. I do not think this change is necessary, since this program doesn't work in IE to begin with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
executeAsyncScript
instead of functionpkg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like #49, please add comments and link to the relevant issue.
resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing
Co-authored-by: Stephen Mathieson <[email protected]>
See: https://github.com/dequelabs/axe-devtools-npm/issues/715
Reviewer checks
Required fields, to be filled out by PR reviewer(s)