Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add @axe-core/webdriverjs #11

Merged
merged 8 commits into from
May 15, 2020
Merged

feat: add @axe-core/webdriverjs #11

merged 8 commits into from
May 15, 2020

Conversation

michael-siek
Copy link
Member

No description provided.

axe-linter[bot]
axe-linter bot suggested changes May 15, 2020
View reviewed changes
Copy link

@axe-linter axe-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the aforementioned accessibility error

packages/webdriverjs/test/fixtures/doc-lang.html
@@ -0,0 +1,6 @@
<!doctype html>
<html>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential accessibility issue: Ensures every HTML document has a lang attribute

@michael-siek michael-siek changed the title feat: add webdriverjs feat: add @axe-core/webdriverjs May 15, 2020
stephenmathieson
stephenmathieson requested changes May 15, 2020
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things

packages/webdriverjs/README.md Outdated Show resolved Hide resolved
packages/webdriverjs/package.json Outdated Show resolved Hide resolved
packages/webdriverjs/package.json Outdated Show resolved Hide resolved
@michael-siek michael-siek marked this pull request as ready for review May 15, 2020 18:58
@michael-siek michael-siek requested review from a team and stephenmathieson May 15, 2020 19:02
@stephenmathieson
Copy link
Member

Reviewed for security

@michael-siek michael-siek merged commit b1c4940 into develop May 15, 2020
@michael-siek michael-siek deleted the add-webdriverjs branch May 15, 2020 22:03
@shaquillaevelyn shaquillaevelyn mentioned this pull request Mar 31, 2022
Closed
@vkochhar-dev vkochhar-dev mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axe-linter axe-linter[bot] axe-linter[bot] requested changes

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-siek @stephenmathieson