Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests make modifications to the source directory #408

Closed
ry opened this issue May 15, 2019 · 1 comment · Fixed by #476
Closed

tests make modifications to the source directory #408

ry opened this issue May 15, 2019 · 1 comment · Fixed by #476

Comments

@ry
Copy link
Member

ry commented May 15, 2019 •
edited
Loading

There are several tests which modify testdata files in the source tree. This is bad practice.

CI should be changed so that the source tree is immutable, to ensure these errors don't creep back after they're fixed.
@ry ry mentioned this issue May 15, 2019
Merged
@axetroy
Copy link
Contributor

axetroy commented May 16, 2019

The existing test case should be changed step by step.

@kt3k kt3k mentioned this issue Jun 2, 2019
Merged
@ry ry closed this as completed in #476 Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check file changes during test
2 participants
@ry @axetroy