Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: Move CI to Github Actions #2863

Closed
lucacasonato opened this issue Sep 5, 2019 · 5 comments
Closed

suggestion: Move CI to Github Actions #2863

lucacasonato opened this issue Sep 5, 2019 · 5 comments

Comments

@lucacasonato
Copy link
Member

We should consider moving CI to GitHub Actions rather than maintaining both Travis and Appveyor for builds. GitHub Actions works with Linux, macOS and Windows and is free for open source projects (actually pretty similar to Azure Pipelines). It will be generally available starting November 13. Actions can also store artifacts for every build. This could be binaries, test results or other arbitrary files. It would also be very useful for contributors because forks would automatically have CI too. This means you don't need to open a PR on this repo to check if your commit/PR passes all of the tests on all platforms.

If this seems like a good idea I'll set this up now so once GitHub Actions is generally available we can move over right away. If this happens #1340 can be closed.

References

https://github.com/features/actions
https://github.blog/2019-08-08-github-actions-now-supports-ci-cd/

@lucacasonato lucacasonato changed the title Move CI to Github Actions suggestion: Move CI to Github Actions Sep 5, 2019
@sholladay
Copy link

It might be a little simpler to just keep everything in Travis. They support Windows, macOS, and Linux now. So AppVeyor is unnecessary. Travis also allows forks to run CI if you want, but it is disabled by default due to the security implications.

@ry
Copy link
Member

ry commented Sep 5, 2019

I would be interested in exploring this - especailly if someone wants to do the work to get it green :)

That said, we are in the middle of a major build system refactor (#2608), I think we should wait for that to complete before introducing any major CI changes.

@lucacasonato
Copy link
Member Author

#2608 has landed so I'll try to get this to work. Building already works on win, macos and linux but tests are still failing. Ill try to get this working ASAP. https://github.com/lucacasonato/deno/runs/215070142

@lucacasonato
Copy link
Member Author

#2968 adds this.

@ry
Copy link
Member

ry commented Oct 3, 2019

moved to #2979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants