Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deno internal code to generate main bundle #2496

Closed
2 tasks
kitsonk opened this issue Jun 11, 2019 · 1 comment · Fixed by #2825
Closed
2 tasks

Use deno internal code to generate main bundle #2496

kitsonk opened this issue Jun 11, 2019 · 1 comment · Fixed by #2825

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Jun 11, 2019

In #2490 it was discussed that depending on code in deno_std as part of Deno is "problematic" because we can't easily get rollup to support extensioned TypeScript. With the deno bundle feature landing, we could in theory for most/all of our internal code bundles use Deno itself to generate its own bundles.

There are a couple considerations:

  • currently bundle source maps aren't parsed out and made available inside Deno. This is talked about in Bundling V2 #2475, but we don't have this yet. We would want that to see where in the bundle internal code "broke" or participated in a stack trace.
  • we would have to embed a bundle loader into the bundle/snapshot.
@ry ry changed the title Use deno bundle to generate main bundle Use deno internal code to generate main bundle Aug 28, 2019
@ry ry closed this as completed in #2825 Sep 2, 2019
@kitsonk
Copy link
Contributor Author

kitsonk commented Sep 3, 2019

For future generations, the need to generate a bundle was removed from the build process, versus actually generating it using the bundling capability of Deno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant