Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android onProgress method alternative #170

Closed
die20 opened this issue Jun 10, 2017 · 3 comments
Closed

Android onProgress method alternative #170

die20 opened this issue Jun 10, 2017 · 3 comments

Comments

@die20
Copy link

die20 commented Jun 10, 2017

Hey,

I'm looking to use this library for a cross-platform app but I noticed that onProgress is not supported on android. Are there any alternatives to getting the current video time on android?
@die20
Copy link
Author

die20 commented Jun 10, 2017

I just noticed that on Youtube.Android.js there is a currentTime() method, could it be that the docs are just not updated to show currentTime() is available on Android?

@die20 die20 closed this as completed Jun 10, 2017
@davidohayon669
Copy link
Owner

Done

@die20
Copy link
Author

die20 commented Jun 11, 2017 •
edited
Loading

:) Awesome.

The reason I closed the issue is because I noticed that currentTime was available on android and not on iOS - I'd prefer to have a single method for getting the current time instead of having to use onProgress for iOS and currentTime for android --- So I forked and made an update that exposes currentTime on iOS.

I'll make a PR in case you want to add it to the repo as well.

#171

@lra-tapptic lra-tapptic mentioned this issue Jul 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidohayon669 @die20