Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malware in dependency lib #2160

Closed
m-s-c-h opened this issue Oct 25, 2022 · 3 comments · Fixed by #2204
Closed

Malware in dependency lib #2160

m-s-c-h opened this issue Oct 25, 2022 · 3 comments · Fixed by #2204
Assignees
Labels
🏦 debt Tech debt 🤖 dependencies Dependency upgrade

Comments

@m-s-c-h
Copy link

m-s-c-h commented Oct 25, 2022

👓 What did you see?

Cucumber has a dependency to the es5-ext library (@cucumber/cucumber -> duration -> d -> es5-ext).
Since march 2022, the es5-ext library contains a malware defined as protestware.
Issue 186 has been filed for the library es5-ext but is still open.

✅ What did you expect to see?

Dependencies free of malware / protestware.
If bound to policies that prohibit any kind of malware and protestware, you are in trouble.

📦 Which tool/library version are you using?

Cucumber 8.3.1

🔬 How could we reproduce it?

Steps to reproduce the behavior:

  1. Install Cucumber version 8.3.1
  2. After npm install see file _postinstall.js in node_module/es5-ext folder

📚 Any additional context?

@m-s-c-h m-s-c-h changed the title Malware in dependent lib Malware in dependency lib Oct 25, 2022
@davidjgoss davidjgoss added 🤖 dependencies Dependency upgrade 🏦 debt Tech debt labels Nov 5, 2022
@davidjgoss
Copy link
Contributor

davidjgoss commented Nov 5, 2022

Thanks for raising @m-s-c-h. It’s a tricky one in terms of policy as (speaking only for myself) I support the principle but it’s not the way I would choose to communicate.

However we can neatly skirt the issue because I’m planning on refactoring out the durations library anyway. I’ll use this issue as a vehicle for that.

cc @mattwynne for visibility

@davidjgoss davidjgoss self-assigned this Nov 5, 2022
@unional
Copy link

unional commented Nov 5, 2022

If you want a remedy to the problem, you can use the overrides mechanism of your package manager of choice.

I have created a video to describe what you need to do: https://youtu.be/dh9UUqsJLok

@m-s-c-h
Copy link
Author

m-s-c-h commented Nov 7, 2022

Many thanks @davidjgoss and @unional!!! In the short run, the override mechanism helps us. And the refactoring sounds great for the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt 🤖 dependencies Dependency upgrade
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants