Build failing on node.js v0.6 and v0.8 - remove Bower to fix #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. The Travis CI build has been failing for node.js v0.6 and v0.8 since 22 May. The last green build I can see was on 18 March.
https://travis-ci.org/cucumber/cucumber-js/builds
The builds are failing during the
npm install
. The build also fails when running it locally under node.js v0.6 and v0.8 (using nvm).Looking at the build output, the npm install errors all mention Bower. Here's an example:
It looks like bower dropped support for node.js v0.8 a couple of months ago: bower/bower@cea53dd
cucumber-js uses an older version of Bower but I wonder if some of Bower's dependencies no longer support node.js v0.8/v0.6.
Removing bower as a dev dependency makes the build go green. I think Bower isn't normally needed for development of cucumber-js. I think it was only needed the first time cucumber-js was registered with the Bower registry (http://bower.io/#registering-packages) which is a one off activity. Would you be happy with removing Bower as a dependency?