Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create annotations using stdout to avoid GITHUB_TOKEN #19

Open
ysbaddaden opened this issue May 28, 2024 · 2 comments
Open

Create annotations using stdout to avoid GITHUB_TOKEN #19

ysbaddaden opened this issue May 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ysbaddaden
Copy link

Extract from external discussion:

You can create annotations manually by writing some specific markup to stdout

crystal-lang/crystal#14608 (comment)

This mechanism was developed before the capability to create annotations using stdout messages was introduced.

crystal-lang/crystal#14608 (comment)

@straight-shoota
Copy link

straight-shoota commented May 28, 2024

I believe there must be another way to create annotations attached to code locations in a more structured manner without writing markup to stdout.
I don't recall how exactly. It might be related to junit output. We configure that it multiple workflows in https://github.com/crystal-lang/crystal/tree/master/.github/workflows (junit_output=.junit/xxx_spec.xml). So maybe GHA picks up the spec results in the .junit folder? I haven't found anything specific about this in the documentation.

@nobodywasishere
Copy link

It shouldn't be too hard to add an output format that matches the format needed for CI, that could be used by this github action to provide what's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants