Incorrect Lint/EmptyExpression: Avoid empty expression

[jwoertink]

After the recent commit 44290a6 I pulled in the master branch to test, and now I get 4 failures for Lint/EmptyExpression from in my comments:

src/avram/callbacks.cr:183:42
[W] Lint/EmptyExpression: Avoid empty expression d t
> # > back the record may not be persisted to the database.
                                         ^
src/avram/callbacks.cr:218:29
[W] Lint/EmptyExpression: Avoid empty expression t b
> # > back the record may not be persisted to the database.
                            ^
src/avram/callbacks.cr:218:51
[W] Lint/EmptyExpression: Avoid empty expression dat
> # > back the record may not be persisted to the database.
                                                  ^
src/avram/callbacks.cr:219:18
[W] Lint/EmptyExpression: Avoid empty expression  `a
> # > Instead use `after_commit`
                 ^
Finished in 936.4 milliseconds

You'll see that first one says line 183. Here's a screenshot of that block

And the other ones on 218 and 219 are essentially the same comments.

[veelenga]

Wow, looking! Sorry about that 😕

[jwoertink]

no worries! Thanks for looking in to it ❤️

[veelenga]

src/avram/callbacks.cr:183:42
src/avram/callbacks.cr:183:44
src/avram/callbacks.cr:218:29
src/avram/callbacks.cr:218:31
src/avram/callbacks.cr:218:51
src/avram/callbacks.cr:218:53
src/avram/callbacks.cr:219:18
src/avram/callbacks.cr:219:20

https://github.com/luckyframework/avram/blob/fe7e79d5cc0673215303f50e1fb97627584b7f79/src/avram/callbacks.cr#L183

https://github.com/luckyframework/avram/blob/fe7e79d5cc0673215303f50e1fb97627584b7f79/src/avram/callbacks.cr#L184

https://github.com/luckyframework/avram/blob/fe7e79d5cc0673215303f50e1fb97627584b7f79/src/avram/callbacks.cr#L218

https://github.com/luckyframework/avram/blob/fe7e79d5cc0673215303f50e1fb97627584b7f79/src/avram/callbacks.cr#L219

This is the file location crystal's compiler points for NilLiteral. There is definitely a bug in the compiler I am going to report. For now, I will disable this particular rule Lint/EmptyExpression since it highly relies on the location of the AST node and there is no way to filter out the incorrect results.

[jwoertink]

@veelenga do we still need to open an issue on crystal?

[veelenga]

@jwoertink yeap, I will do in a bit. Does this block you somehow?

[jwoertink]

Cool. Nope, I'm good on my end 😄 thanks!