Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transport optional (potential WASM support) #237

Closed
dakom opened this issue Sep 10, 2024 · 1 comment · Fixed by #238
Closed

Make transport optional (potential WASM support) #237

dakom opened this issue Sep 10, 2024 · 1 comment · Fixed by #238

Comments

@dakom
Copy link
Contributor

dakom commented Sep 10, 2024

I believe this should be two steps:

  1. Feature-gating a bit more granularly

default could remain as-is. Would be something like a change from this:

[features]
default = ["std", "client"]
client = ["std", "dep:tonic", "tonic/codegen", "tonic/transport", "tonic/prost"]
server = ["std", "dep:tonic", "tonic/codegen", "tonic/transport", "tonic/prost"]

to this:

[features]
default = ["std", "client", "transport"]
client = ["std", "dep:tonic", "tonic/codegen", "tonic/prost"]
server = ["std", "dep:tonic", "tonic/codegen", "tonic/prost"]
transport = ["tonic/transport"]
  1. providing a way to tonic_build without the transport feature. I'm not sure if that's part of the proto-compiler tool

This comment looks relevant: hyperium/tonic#1538 (comment)

I'd be happy to make a PR, since I was able to build a client partially with the feature-gating locally, but couldn't proceed with the proto-compiler tool (instructions don't work, or I did something wrong, it requires having a --ics and --nft param)

@dakom
Copy link
Contributor Author

dakom commented Sep 11, 2024

couldn't proceed with the proto-compiler tool

ah, missed the warning to run via scripts/sync-protobuf.sh, that works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant