Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwltool validate will pass workflows with fatal issues in included processes #1304

Open
ghost opened this issue Jun 12, 2020 · 3 comments
Open

Comments

@ghost
Copy link

ghost commented Jun 12, 2020

cwltool 3.0.20200324120055

Consider the following workflow: https://github.com/NCI-GDC/gdc-dnaseq-cwl/blob/18affdd927cc388fab2c113dc2ec6df782af2a52/workflows/bamfastq_align/transform.cwl

This passes cwltool --validate. However, there is an issue with an enclosed workflow: The workflow gdc-dnaseq-cwl/workflows/bamfastq_align/fastq_clean_pe.cwl does not supply a required input reads_in_memory to the tool gdc-dnaseq-cwl/tools/fastq_cleaner_pe.cwl

@ghost
Copy link
Author

ghost commented Nov 10, 2020

@tetron , @mr-c I feel this is an important issue to fix because we've run into several workflows in the wild that fail to run because they pass validation on the top level but contain errors in child processes.

@mr-c
Copy link
Member

mr-c commented Dec 15, 2020

INFO /home/michael/cwltool/env3.8/bin/cwltool 3.0.20201205091845
ERROR Tool definition failed validation:
https://github.com/NCI-GDC/gdc-dnaseq-cwl/blob/18affdd927cc388fab2c113dc2ec6df782af2a52/workflows/bamfastq_align/transform.cwl:91:65: mapping values are
                                                                                                                                      not allowed here

@mr-c
Copy link
Member

mr-c commented Dec 15, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant