Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase refund time window to 24 hours #1721

Open
binarybaron opened this issue Jul 22, 2024 · 0 comments
Open

Increase refund time window to 24 hours #1721

binarybaron opened this issue Jul 22, 2024 · 0 comments
Labels
asb Related to the automated swap backend enhancement New feature or request

Comments

@binarybaron
Copy link
Collaborator

binarybaron commented Jul 22, 2024

I think we should increase the refund time window from 12 hours to 24 hours.

My reasoning is:

  1. Being punished as an end user is very unpleasant
  2. The risk is currently shifted unproportionally on the side of Bob
  3. There's no downside to this as far as I can see

This will be a breaking change unless:

  • We can look into Bob and Alice having a set of refund windows that are acceptable to him
  • This way we can make this change backwards compatible by allowing both 12 hours as well as 24 hours (for a transitionary period)

But I'd also be fine with this just being a breaking change.

@binarybaron binarybaron added enhancement New feature or request asb Related to the automated swap backend labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asb Related to the automated swap backend enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant