Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm a swap before continuing #1608

Open
tqwewe opened this issue Apr 13, 2024 · 1 comment
Open

Confirm a swap before continuing #1608

tqwewe opened this issue Apr 13, 2024 · 1 comment
Labels
cli Related to the swap CLI tool enhancement New feature or request

Comments

@tqwewe
Copy link

tqwewe commented Apr 13, 2024

Describe the bug
When performing a swap, there's no interaction in the cli to confirm the amount, the price, etc thats about to be swapped.
Instead it continues with the swap immediately after executing swap buy-xmr ....

This has caused me to attempt to buy with a seller, and saw the price was absolutely horrible and so I had to cancel quickly with CTRL C. This left my bitcoin to be locked, and it's yet to be determined if I'll have it refunded or not.

Lost/trapped Funds
Need to wait 11 hours first as indicated by the GUI

Platform (please complete the following information):

  • CLI or ASB: CLI
  • Software Version: 0.12.3
  • Operating System: MacOS
@binarybaron
Copy link
Collaborator

This is a valid point in terms of UX. However we are trying to keep the CLI non-interactive such that it can be easily controlled by other software.
I'm not sure how we can do both. Perhaps we need an interactive and a non interactive mode.

@binarybaron binarybaron added enhancement New feature or request cli Related to the swap CLI tool labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the swap CLI tool enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@tqwewe @binarybaron and others