Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closed root shadow dom support proposal #7074

Closed
pavelfeldman opened this issue Nov 10, 2023 · 2 comments
Closed

closed root shadow dom support proposal #7074

pavelfeldman opened this issue Nov 10, 2023 · 2 comments

Comments

@pavelfeldman
Copy link
Contributor

Codemirror5 currently does not work in a closed shadow root. A fix like this would make it work. Would you be interested in a PR? getRootNode() exists in all modern browsers for years now, not sure how much of a compatibility impact it is for cm5 deployment.

@marijnh
Copy link
Member

marijnh commented Nov 10, 2023

CodeMirror also targets old browsers, so this would have to be wrapped in a helper function with a fallback.

Also, did you test on Safari? That browser still has rather broken selection management in shadow DOM.

@pavelfeldman
Copy link
Contributor Author

CodeMirror also targets old browsers, so this would have to be wrapped in a helper function with a fallback.

Sounds good

Also, did you test on Safari? That browser still has rather broken selection management in shadow DOM.

I did not, but I will.

I'll read it as a potential interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants