Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk usage not working in prod #4472

Open
AndrewJGaut opened this issue May 17, 2023 · 0 comments
Open

Disk usage not working in prod #4472

AndrewJGaut opened this issue May 17, 2023 · 0 comments
Labels
p1 Do it in the next two weeks.

Comments

@AndrewJGaut
Copy link
Contributor

Disk usage is not working in production; users' disk is not being accurately computed when deleting/creating bundles. for instance, see here.

It would appear the changes I made in this PR are not working properly in production.

Luckily, I can revert back to the old method of computing disk quota and it will recompute their quota (see here and, in particular, update_user_disk_used here, which uses a query here to just recompute the user disk quota from scratch).

In short, I can effectively revert this change for the time being and the user's disk usage will automatically be reset to their true usage whenever they next make any changes that affect disk quota (e.g. upload a bundle or delete a bundle). I will investigate why this change passed the test and seems to work sometimes (e.g. when I tested it in dev) but not at other times. I suspect there may be a race condition somewhere.

@AndrewJGaut AndrewJGaut added the p1 Do it in the next two weeks. label May 17, 2023
@AndrewJGaut AndrewJGaut self-assigned this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 Do it in the next two weeks.
Projects
None yet
Development

No branches or pull requests

1 participant