feat: make teams location params optional #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexscaria
force-pushed
the
rex/update-teams-docs
branch
from
2988c50 to
84f579c
Compare
|
Sorry missed this. Please include in next release. |
|
changelog detected ✅ |
teams_locations.go
Outdated
| IPv4DestinationBackup string `json:"ipv4_destination_backup"` | ||
| DNSDestinationIPsID string `json:"dns_destination_ips_id"` | ||
| DNSDestinationIPv6BlockID string `json:"dns_destination_ipv6_block_id"` | ||
| IPv4Destination string `json:"ipv4_destination,omitempty"` |
There was a problem hiding this comment.
do you want these to be *string to omit it entirely vs being empty?
|
I will take *string
Thanks
*Rex Scaria | | ***@***.*** ***@***.***> |
+1-480-628-9203*
…On Thu, Dec 19, 2024 at 8:29 PM Jacob Bednarz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In teams_locations.go
<#3758 (comment)>
:
> @@ -32,10 +32,10 @@ type TeamsLocation struct {
Ip string `json:"ip,omitempty"`
Subdomain string `json:"doh_subdomain"`
AnonymizedLogsEnabled bool `json:"anonymized_logs_enabled"`
- IPv4Destination string `json:"ipv4_destination"`
- IPv4DestinationBackup string `json:"ipv4_destination_backup"`
- DNSDestinationIPsID string `json:"dns_destination_ips_id"`
- DNSDestinationIPv6BlockID string `json:"dns_destination_ipv6_block_id"`
+ IPv4Destination string `json:"ipv4_destination,omitempty"`
do you want these to be *string to omit it entirely vs being empty?
—
Reply to this email directly, view it on GitHub
<#3758 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFN7RG57BBT2XWQCEIGSGD2GNXG5AVCNFSM6AAAAABT5OZWHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJWGUZDANJQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
rexscaria
force-pushed
the
rex/update-teams-docs
branch
from
84f579c to
603f60f
Compare
|
I have updated the code to use *string. this is good to merge after validations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.