Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/certificate_authorities: fixes for methods to interact with Hostname Associations API #3742

Merged

Conversation

ebisso
Copy link
Contributor

@ebisso ebisso commented Dec 17, 2024

Description

There were flaws in the initial implementation of certificate_authorities_hostname_associations that I discovered after manually testing the changes in #3740 on real API server:

  1. Parameter mtls_certificate_id was not properly added as query param in ListCertificateAuthoritiesHostnameAssociation and was not validated in the test of this method.
  2. Response structure was incorrectly transposed during tests, and was missing the envelope. As such, the response failed to deserialize on the real server.

Has your change been tested?

Performed manual testing against real server
Updated Automated tests to validate both issues

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

changelog detected ✅

@ebisso ebisso changed the title Bugfix/certificate authorities param Bugfix/certificate_authorities: fixes for implementation of methods to interact with Hostname Associations API Dec 17, 2024
@ebisso ebisso changed the title Bugfix/certificate_authorities: fixes for implementation of methods to interact with Hostname Associations API Bugfix/certificate_authorities: fixes for methods to interact with Hostname Associations API Dec 17, 2024
@ebisso ebisso marked this pull request as ready for review December 17, 2024 15:39
@ebisso ebisso requested a review from jacobbednarz as a code owner December 17, 2024 15:39
@jacobbednarz jacobbednarz merged commit f2d8cac into cloudflare:master Dec 18, 2024
2 checks passed
@github-actions github-actions bot added this to the v0.112.0 milestone Dec 18, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This functionality has been released in v0.112.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants