Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns_destination_ips_id and ipv4_destination_backup to TeamsLocation #3699

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

dfialho
Copy link
Contributor

@dfialho dfialho commented Dec 4, 2024

Add these missing fields to TeamsLocation

Description

Has your change been tested?

Ran it against my account and updated unit tests.

ctx := context.Background()
accountId := ""
locations, _, err := api.TeamsLocations(ctx, accountId)
if err != nil {
	log.Fatal(err)
}
for _, l := range locations {
	fmt.Println(l)
}

location := locations[0]
location.IPv4DestinationBackup = "172.64.36.3"
location.DnsDestinationIpsIds = "0e4a32c6-6fb8-4858-9296-98f51631e8e5"
location, err = api.UpdateTeamsLocation(ctx, accountId, location)
if err != nil {
	log.Fatal(err)
}
println(location.DnsDestinationIpsIds)
println(location.IPv4DestinationBackup)

Types of changes

What sort of change does your code introduce/modify?

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@dfialho dfialho requested a review from jacobbednarz as a code owner December 4, 2024 11:30
Copy link
Contributor

github-actions bot commented Dec 4, 2024

changelog detected ✅

teams_locations.go Outdated Show resolved Hide resolved
Took the opportunity to add
`ipv4_destination_backup` as well that was also
missing
@dfialho dfialho force-pushed the add-dns_destination_ips_id branch from 08ea00b to 1b97e39 Compare December 5, 2024 10:48
teams_locations.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit a058563 into cloudflare:master Dec 5, 2024
7 checks passed
@github-actions github-actions bot added this to the v0.112.0 milestone Dec 5, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This functionality has been released in v0.112.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants