Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "contains" field to custom cache key #2935

Merged

Conversation

anthocf
Copy link
Contributor

@anthocf anthocf commented Aug 27, 2024

The Cloudflare CDN team has introduced changes to the Cache Rules API so customers can shard cache based on headers they include in the cache_key.custom_key.header.contains field of their cache rules. I am working on Terraform support and need this change to go in first.

Description

This change adds support for a new field. It is required for the Terraform provider support to work.

Has your change been tested?

Unit tests in this PR.

Screenshots (if appropriate):

N/a

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@anthocf anthocf requested a review from jacobbednarz as a code owner August 27, 2024 15:33
Copy link
Contributor

github-actions bot commented Aug 27, 2024

changelog detected ✅

@anthocf anthocf force-pushed the anthocf/cache-key-headers-contains branch from 964099d to daafdee Compare August 27, 2024 15:48
.changelog/2935.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 9f93802 into cloudflare:master Aug 28, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.103.0 milestone Aug 28, 2024
Copy link
Contributor

This functionality has been released in v0.103.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants