Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still alive? #73

Closed
andy-maier opened this issue Dec 2, 2020 · 13 comments
Closed

Is this project still alive? #73

andy-maier opened this issue Dec 2, 2020 · 13 comments
Assignees

Comments

@andy-maier
Copy link

andy-maier commented Dec 2, 2020

Sorry for asking so directly, but the last release was in 10/2018, and since then none of the PRs that had been provided have been answered to or merged.

@untitaker
Copy link
Collaborator

Hey, I'm no longer using this project. I think I would be happy to hand this over to any person who seems to have a trustworthy track record in OSS (not any volunteer since this package is depended upon by quite a few people)

@auvipy
Copy link
Collaborator

auvipy commented Mar 18, 2021

Hey, I'm no longer using this project. I think I would be happy to hand this over to any person who seems to have a trustworthy track record in OSS (not any volunteer since this package is depended upon by quite a few people)

Hi, I am a celery core team member, we use this in celery if you add me to maintain this project I can keep it updated & released for the sake of compatibility with celery & airflow.

@untitaker
Copy link
Collaborator

@auvipy added

ping me for release though, I will add you later to PyPI but I wanna take a quick look at things you merged before the next big release after such a long time.

@auvipy
Copy link
Collaborator

auvipy commented Mar 19, 2021

ok sure

@davidism
Copy link
Member

davidism commented Apr 24, 2021

@auvipy heads up, if you are a maintainer now, this will stop working when Click 8 is released (in a few weeks) because the shell completion system was rewritten.

Celery currently depends on Click < 8, but Flask 2 will depend on Click >= 8, so anyone using Flask with Celery will not be able to upgrade until Celery updates their pin, which they can't unless they drop this dependency or it gets updated.

cc @ThiefMaster

@auvipy
Copy link
Collaborator

auvipy commented Apr 24, 2021

Yup some big overhaull needed

@auvipy
Copy link
Collaborator

auvipy commented Apr 25, 2021

I need some details on click changes that need to be worked on to make it v8.0 compatible

@auvipy auvipy self-assigned this Apr 25, 2021
@davidism
Copy link
Member

@auvipy I'm not familiar with click-repl, so I'm not exactly sure what might be needed. However, the only thing that significantly changed in an incompatible way was the shell completion system. Commands, groups, parameters, and types all have shell_complete methods now instead of having to go through internals. The completion system itself is extensible and a public API, it has moved to the click.shell_completion module. https://click.palletsprojects.com/en/master/shell-completion/#custom-type-completion Happy to answer more questions on the Click channel on our Discord: https://discord.gg/pallets

@andy-maier
Copy link
Author

@auvipy Hey, this is great. Thanks!

@auvipy
Copy link
Collaborator

auvipy commented Nov 6, 2021

we have a new release. @untitaker it would be a very helpful if i get acess to other packages like click-didyoumean &
click-plugins as we use them in celery :) ofcourse if you have the ability to invite on those repo as well.

@auvipy
Copy link
Collaborator

auvipy commented Nov 6, 2021

I am closing this since the project is alive now with new release.

@auvipy auvipy closed this as completed Nov 6, 2021
@untitaker
Copy link
Collaborator

@auvipy those packages have their own maintainers respectively, if you want to have access on them please create a new issue there respectively. I can take care of the details if the respective maintainer agrees.

@auvipy
Copy link
Collaborator

auvipy commented Nov 6, 2021

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants