Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a default skin tone in via config #17736

Open
pomek opened this issue Jan 10, 2025 · 0 comments
Open

Define a default skin tone in via config #17736

pomek opened this issue Jan 10, 2025 · 0 comments
Assignees
Labels
package:emoji squad:platform Issue to be handled by the Platform team. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@pomek
Copy link
Member

pomek commented Jan 10, 2025

📝 Provide a description of the new feature

By default, all emojis use the Default skin tone option as a variant.

While the feature preserves changes when a user updates the variant, it would be good to allow users to define their skin tone via the configuration option.

Hence, let's introduce the emoji.skinTone option with supported values:

type EmojiSkinTone = 'default' | 'dark' | 'medium-dark' | 'medium' | 'medium-light' | 'light';

Perhaps it should be exported from the package to make it visible in API docs.

Definition of Done

  • When the emoji.skinTone option is specified, its value is used instead of default when showing the emojis.
  • The' default' value is used instead if the option is missing in a configuration.
  • When a user modifies the skin tone, the value is preserved (like it's now).
  • Add the new option in the feature guide.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@pomek pomek added package:emoji squad:platform Issue to be handled by the Platform team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Jan 10, 2025
@przemyslaw-zan przemyslaw-zan self-assigned this Jan 10, 2025
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:emoji squad:platform Issue to be handled by the Platform team. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

3 participants