implement TikZ/PGF baseline support #2477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xworld21
commented
Jan 6, 2025
| @@ -77,13 +77,15 @@ DefConstructor('\lxSVG@insertpicture{}', sub { | |||
| if ($document->getNodeQName($current) =~ /^svg:/) { # Already in svg:svg ? | |||
| # Seemingly this positioning is correct; otherwise inherit from context | |||
| my ($x, $y) = (-$props{minx}, -$props{miny}); | |||
| $y -= $props{depth}->pxValue if $props{depth}->pxValue; | |||
There was a problem hiding this comment.
Actually I haven't tested this, how do I do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2462. Note that it does not fix the baseline issues in the 'unit tests by Silviu'. This is a good sign, because those tests do not modify the baseline, ever; they are broken for a different minx/miny related reason.