Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BraveAds dependency from dom_distiller #28751

Closed
aseren opened this issue Feb 24, 2023 · 1 comment · Fixed by brave/brave-core#17366
Closed

Remove BraveAds dependency from dom_distiller #28751

aseren opened this issue Feb 24, 2023 · 1 comment · Fixed by brave/brave-core#17366
Assignees
@aseren
Labels
dev-concern feature/ads OS/Desktop QA/No release-notes/exclude
Milestone
1.51.x - Release

Comments

@aseren
Copy link

aseren commented Feb 24, 2023

No description provided.

@aseren aseren self-assigned this Feb 24, 2023
@aseren aseren mentioned this issue Feb 24, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 1, 2023
@bridiver
Copy link
Contributor

what is the reasoning for this?

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
dev-concern feature/ads OS/Desktop QA/No release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Remove dom_distiller dependency from BraveAds brave/brave-core
3 participants
@bridiver @brave-builds @aseren