Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize the passing of ground truth (poses, meshes etc.) in the scene optimizer and individual modules #361

Open
akshay-krishnan opened this issue Oct 22, 2021 · 1 comment · May be fixed by #376
Assignees
Labels

Comments

@akshay-krishnan
Copy link
Collaborator

Currently, the complexity of the run() methods in the individual modules and the scene optimizer is increasing due to the overhead produced by ground truth and metrics as discussed in #295 .

@akshay-krishnan akshay-krishnan changed the title Organize the passing of ground truth (poses, meshes etc.) in the scene optimizer and to individual modules Organize the passing of ground truth (poses, meshes etc.) in the scene optimizer and individual modules Oct 22, 2021
@akshay-krishnan
Copy link
Collaborator Author

Some of my thoughts:

The metrics are the same for a type of module irrespective of the implementation. Ex: all translation averaging methods would have the same metrics. So we could move the computation of metrics into a different method in the base class. This method would accept the results produced by run() and the ground truth, and compute the metrics. It would be called by the create_computation_graph method after calling run().

This does not solve the problem of complexity in the scene optimizer.
One partial solution (to reduce some complexity) is to have a container for ground truth data (poses, meshes, intrinsics etc.), and pass these without any manipulation to the individual modules from the scene optimizer. The individual modules can use whatever part of ground truth they like. The downside to this is of course that computation to manipulate ground truth might be repeated in the individual modules.

@travisdriver travisdriver self-assigned this Nov 5, 2021
@travisdriver travisdriver linked a pull request Nov 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants