You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the complexity of the run() methods in the individual modules and the scene optimizer is increasing due to the overhead produced by ground truth and metrics as discussed in #295 .
The text was updated successfully, but these errors were encountered:
akshay-krishnan
changed the title
Organize the passing of ground truth (poses, meshes etc.) in the scene optimizer and to individual modules
Organize the passing of ground truth (poses, meshes etc.) in the scene optimizer and individual modules
Oct 22, 2021
The metrics are the same for a type of module irrespective of the implementation. Ex: all translation averaging methods would have the same metrics. So we could move the computation of metrics into a different method in the base class. This method would accept the results produced by run() and the ground truth, and compute the metrics. It would be called by the create_computation_graph method after calling run().
This does not solve the problem of complexity in the scene optimizer.
One partial solution (to reduce some complexity) is to have a container for ground truth data (poses, meshes, intrinsics etc.), and pass these without any manipulation to the individual modules from the scene optimizer. The individual modules can use whatever part of ground truth they like. The downside to this is of course that computation to manipulate ground truth might be repeated in the individual modules.
Currently, the complexity of the run() methods in the individual modules and the scene optimizer is increasing due to the overhead produced by ground truth and metrics as discussed in #295 .
The text was updated successfully, but these errors were encountered: