Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface between loaders and GtsfmData #263

Open
travisdriver opened this issue Sep 5, 2021 · 2 comments · May be fixed by #376
Open

Interface between loaders and GtsfmData #263

travisdriver opened this issue Sep 5, 2021 · 2 comments · May be fixed by #376
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@travisdriver
Copy link
Collaborator

this seems like this is a more general purpose function that should go into GtsfmData or something, like

class GtsfmData:
     @classmethod
     def from_colmap_model(cls, colmap_model_dir: str) -> "GtsfmData":

would that make sense?

Originally posted by @johnwlambert in #258 (comment)

@travisdriver travisdriver added enhancement New feature or request question Further information is requested labels Sep 5, 2021
@travisdriver
Copy link
Collaborator Author

I think this is a good idea. However, I think the GtsfmData class needs to be restructured slightly for the loaders to be able to utilize it (e.g., storing image names for reading, loaders store calibrations and extrinsics separately in lists while GtsfmData stores a Dict of PineholeCameraCal3Bundler).

@travisdriver travisdriver added help wanted Extra attention is needed and removed question Further information is requested labels Sep 8, 2021
@travisdriver
Copy link
Collaborator Author

#258 (comment)

@travisdriver travisdriver linked a pull request Nov 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant