Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gn_args support? #68

Open
JerrySievert opened this issue Jun 24, 2023 · 3 comments
Open

gn_args support? #68

JerrySievert opened this issue Jun 24, 2023 · 3 comments

Comments

@JerrySievert
Copy link
Contributor

given that some embedders need to use different arguments that would normally be passed to gn gen, is there a mechanism for this?

I haven't been able to find any in the existing code other than the predefines in the cmake file. is this currently possible?

@bnoordhuis
Copy link
Owner

Not supported at the moment but flags can be added on a case-by-case basis (ex. v8_enable_i18n_support)

@JerrySievert
Copy link
Contributor Author

thanks ben!

the biggest ones i see for plv8 are:

  • is_component_build=false
  • v8_use_external_startup_data=false

as noted before, v8_enable_i18n_support would be nice, we have a few users who have used it, but it's generally not used.

@bnoordhuis
Copy link
Owner

v8_use_external_startup_data should not be difficult.

is_component_build=false is basically what we have today, I think? is_component_build=true on the other hand is #60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants