Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Option to disable HttpOnly on cookie? #57

Closed
tomtaylor opened this issue Jan 19, 2015 · 2 comments
Closed

Option to disable HttpOnly on cookie? #57

tomtaylor opened this issue Jan 19, 2015 · 2 comments

Comments

@tomtaylor
Copy link
Contributor

I'd like to share a cookie between multiple services, some of which make cross domain requests using JS. Currently, HttpOnly is set to true when the cookie is set and cleared. It'd be great to provide an option to disable this.

Instinctively, I'd set this using a -cookie-httponly flag, but there's already a -cookie-https-only flag. I'd be inclined to rename this to -cookie-secure, which I think would be closer to the expected naming, but it's a breaking change.

I'm happy to submit a PR to do this, but I wanted to check your thoughts on renaming the https flag.
This was referenced Jan 19, 2015
Merged
Closed
@tomtaylor
Copy link
Contributor Author

I just went ahead and submitted the two things as separate PRs.

@jehiah
Copy link
Member

jehiah commented Jan 19, 2015

closed by #58

@jehiah jehiah closed this as completed Jan 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomtaylor @jehiah