Updating imports without moving files

[sQVe]

Hey 👋,

One issue we're having is that when you run destiny on the src folder we fix the imports but not on other folders that also import those files like a test folder. This issue is a bit tricky as one might argue that if we specify only the src folder it should only restructure and fix the src folder.

I do think that most people would assume that the imports in test was fixed too. If you run destiny on itself you have to, in many cases, manually go and repair the test imports.

[AnatoleLucet]

Do you have an idea of how we could check who's importing a specific file from src without checking every files/folders in src's parent? That would really be time-consuming.

[benawad]

I think we need 2 inputs from the user

1. The files to restructure ["src/utils", "src/pages", etc...]
2. The files to fix imports for ["src", "tests"]

Sometimes these values are the same, sometimes they are different

[jesperordrup]

@benawad

That looks like solving the issue. Input either as a config file or parameters.

[waynevanson]

What if by default we check up to the root for a project, and run it for the top level package.json? This way it works with monorepos.

It's a pretty sane default IMO.

would work for these cases:

# single repo
/home/user/documents/
    project/
         src/
           # files...
         tests/
            # files.. 
         package.json

# monorepo
/home/user/documents/
    project-monorepo/
        packages/
            project-1/
                 src/
                   # files...
                 tests/
                    # files.. 
                 package.json
            project-2/
                 src/
                   # files...
                 tests/
                    # files.. 
                 package.json
    package.json

[sQVe]

What if by default we check up to the root for a project, and run it for the top level package.json? This way it works with monorepos.

I think we should only change files that the user allows us to change. If the user points at a path we should only take that path into consideration.

[jesperordrup]

I think that destiny should assume as much as possible and ask a few questions first time. Zeit now style

Assume that root is package.json is but ask for conf.
Assume that all can be moved but ask for conf or glob.
Save responses in config
Next time run without questions.

[waynevanson]

Assume that root is package.json is but ask for conf.

I would like this to be like the example I've mentioned, so it works with workspaces (searching up the tree for package.json).

ask a few questions first time

And add a CLI flag, maybe -i for interactive, to ask questions if it isn't the first time.

Assume that all can be moved but ask for conf or glob.

If everything can be moved, I thought it might be risky. But since the user will dry run first, it wouldn't be so risky

I think that the CLI could display the folder structure it changes and then list all paths changes that aren't in the root.

[AnatoleLucet]

Just thought about a --static flag. E.g. destiny ./src --static ./tests...