alinghash does not move comments correctly #974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch. Comments don't appear in the AST and they are pretty hard to deal with in general. Not sure if we can work-around this in a simple manner. |
|
I don't think we can detect badly aligned comments at all right now. But perhaps @tamird is right that comment indentation is best handled in each cop that deals with indentation and alignment, since that's where the knowledge about correct indentation lies. We've got a fair amount of work ahead of us. I'll try to start looking at this pretty soon. |
bbatsov
added a commit
that referenced
this pull request
Apr 27, 2014
[Fix #974] New cop CommentIndentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonas054 @bbatsov mind taking a look at this?