Move Style/EmptyLineAfterGuardClause cop to Layout
#5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
move_empty_line_after_guard_clause_to_layout
branch
from
c5f2a97 to
65aa8ae
Compare
Follow up of rubocop#5720 (comment). This PR moves `Style/EmptyLineAfterGuardClause` cop to `Layout` department. I remember about the proposal that this cop name `EmptyLinesAroundGuardClause` is good, however I'm not sure about it. On the other hand, since I think that this cop should be in the `Layout` department, so this PR moves the department.
koic
force-pushed
the
move_empty_line_after_guard_clause_to_layout
branch
from
65aa8ae to
a7c57db
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #5720 (comment).
This PR moves
Style/EmptyLineAfterGuardClausecop toLayoutdepartment.I remember about the proposal that this cop name
EmptyLinesAroundGuardClauseis good, however I'm not sure about it 💦On the other hand, since I think that this cop should be in the
Layoutdepartment, so this PR moves the department.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.