-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to
as method parameter in default config
#5626
Allow to
as method parameter in default config
#5626
Conversation
CHANGELOG.md
Outdated
@@ -2,6 +2,9 @@ | |||
|
|||
## master (unreleased) | |||
|
|||
### Changes | |||
* Change `Naming/UncommunicativeMethodParamName` add `to` to allowed names in default config. ([@unused][]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write the link to this PR at the beginning 😃
- * Change `Naming/UncommunicativeMethodParamName` add `to` to allowed names in default config. ([@unused][])
+ * [#5626](https://github.com/bbatsov/rubocop/pull/5626): Change `Naming/UncommunicativeMethodParamName` add `to` to allowed names in default config. ([@unused][])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry and thx 😄
Would it be meaningful to add some common preposition, such as "in", "on", "at", etc.? |
Perhaps, although I've rarely seen those as method names. |
Yeah, but |
Can you check the failing build on Travis CI? |
I cannot think of an example using "in", "on", "at" except using some as pre-/suffixes. Happy to add if someone provides a legit code example :) |
I manually adapted the documentation, did not know about the generation task - did I miss it in the contribution guide? If it is missing, it might be a good hint to have. |
It's in the PR template, but probably you didn't notice it there. Can you rebase on top of |
Add `to` to AllowedNames in default configuration for cop Naming/UncommunicativeMethodParamName in order to allow common methods handling date ranges with parameter `set_date_range(from, to)`
Fixes issue with whitespace in docs, see rubocop#5626.
f36647f
to
0228bb5
Compare
Thx, I'll double check next time. Rebased. |
What about |
Sure. |
Add
to
to AllowedNames in default configuration for copNaming/UncommunicativeMethodParamName in order to allow common
methods handling date ranges with parameter
set_date_range(from, to)